-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui5-user-menu): introduce new component #10244
Conversation
add initials property of ProfileMenuAccount
}); | ||
|
||
if (!eventPrevented) { | ||
item.fireEvent("close-menu"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Custom events have description about their bubble, cancelable configurations. This means that we need to fire events via fireDecoratorEvent
in order to apply these configurations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some reason, it is not working. I guess because the MenuItem (which we extend) is still using the fireEvent. We can sync for that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most probably this will be resolved when the following PR is merged https://github.com/SAP/ui5-webcomponents/pull/10247/files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, Adi, you are right - @tsanislavgatev
extract getter
add Advanced sample
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor. Otherwise it LGTM
The change introduces several components - UserMenu, UserMenuAccount, and UserMenuItem to build application forms more easily and according to the latest design guidelines.
Overview
The UserMenu is a layout component that offers a range of options specific to the user and can contain product-specific functionality.
Structure
The basic menu contains the user account of the header area on the top and content below the number of UserMenuItems. And the Sign Out button.
The are also options to a add Manage Account button.
Or to show Other accounts if they are available and ba utton for adding additional accounts.
Responsiveness
The UserMenu component reacts and changes its layout on predefined breakpoints.
Width-Full width
Height-Full height
Width, fixed-320px (20rem)
Height, min-Hug contents
Height, max-Screen height-52px(3.25rem) top 16px (1rem) bottom
API
UserMenu
props
slot
UserMenuAccount
props
UserMenuItem
Extend MenuItem api.
Test Pages
fiori/test/pages/UserMenu.html